update: added logs #142
Closed
update: added logs #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemankv
force-pushed
the
update/logs-addition
branch
from
5204c86 to
6631d93
Compare
heemankv
force-pushed
the
update/logs-addition
branch
from
f2b1278 to
54e83e6
Compare
Mohiiit
requested changes
Oct 9, 2024
| // Here in case of ethereum we are not publishing the state diff because we are doing it all | ||
| // together in update_state job. So we don't need to send the blob here. | ||
| Ok("NA".to_string()) | ||
| } | ||
|
|
||
| async fn verify_inclusion(&self, _external_id: &str) -> Result<DaVerificationStatus> { | ||
| tracing::info!("Verifying inclusion on ethereum"); |
There was a problem hiding this comment.
shall we add external id in the tracing as well?
| @@ -49,6 +49,7 @@ impl DataStorage for AWSS3 { | |||
| let response = self.client.get_object().bucket(&self.bucket).key(key).send().await?; | |||
| let data_stream = response.body.collect().await.expect("Failed to convert body into AggregatedBytes."); | |||
| let data_bytes = data_stream.into_bytes(); | |||
| tracing::info!("Got data from s3 bucket {:?}", self.bucket); | |||
There was a problem hiding this comment.
maybe add key as well? in case we have it wrong? wdyt
| @@ -63,6 +64,7 @@ impl DataStorage for AWSS3 { | |||
| .send() | |||
| .await?; | |||
|
|
|||
| tracing::info!("Put data to s3 bucket {:?}", self.bucket); | |||
| @@ -137,6 +141,7 @@ impl Database for MongoDb { | |||
| } | |||
| }; | |||
| self.update_job_optimistically(job, update).await?; | |||
| tracing::info!("DB: Updated job with id {:?} to status {:?}", job.id, new_status); | |||
There was a problem hiding this comment.
Suggested change
| tracing::info!("DB: Updated job with id {:?} to status {:?}", job.id, new_status); | |
| tracing::info!("DB: Updated status for job with id {:?} to status {:?}", job.id, new_status); |
| @@ -72,6 +71,7 @@ impl Job for DaJob { | |||
| internal_id: String, | |||
| metadata: HashMap<String, String>, | |||
| ) -> Result<JobItem, JobError> { | |||
| tracing::debug!("DA JOB: Creating job with internal_id {:?}", internal_id); | |||
There was a problem hiding this comment.
I have less context, so wdyt?
Suggested change
| tracing::debug!("DA JOB: Creating job with internal_id {:?}", internal_id); | |
| tracing::info!("DA JOB: Creating job with internal_id {:?}", internal_id); |
| CairoJobStatus::INVALID => { | ||
| Ok(TaskStatus::Failed(format!("Task is invalid: {:?}", res.invalid_reason.unwrap_or_default()))) | ||
| let invalid_reason = res.invalid_reason.unwrap_or_default(); | ||
| tracing::error!("Sharp Service: Task is invalid: {:?}", invalid_reason.clone()); |
| let program_output: Vec<U256> = vec_u8_32_to_vec_u256(program_output.as_slice())?; | ||
| let onchain_data_hash: U256 = slice_u8_to_u256(&onchain_data_hash)?; | ||
| let onchain_data_size = U256::from_be_bytes(onchain_data_size); | ||
| let tx_receipt = | ||
| self.core_contract_client.update_state(program_output, onchain_data_hash, onchain_data_size).await?; | ||
| tracing::info!("Ethereum Settlement Client: Updated state with calldata {:?}", tx_receipt.transaction_hash); |
There was a problem hiding this comment.
message not relevant, need to update this
| Ok(SettlementVerificationStatus::Pending) | ||
| } else { | ||
| tracing::info!("Transaction {} is settled", tx_hash); |
There was a problem hiding this comment.
Suggested change
| tracing::info!("Transaction {} is settled", tx_hash); | |
| tracing::info!("Transaction {} is verified", tx_hash); |
|
|
||
| let tx_hash = Felt::from_hex(tx_hash)?; | ||
| loop { | ||
| let tx_receipt = self.account.provider().get_transaction_receipt(tx_hash).await?; | ||
| if tx_receipt.block.is_pending() { | ||
| retries += 1; | ||
| if retries > MAX_RETRIES_VERIFY_TX_FINALITY { | ||
| tracing::error!("Max retries exceeeded while waiting for tx {tx_hash} finality."); |
There was a problem hiding this comment.
Suggested change
| tracing::error!("Max retries exceeeded while waiting for tx {tx_hash} finality."); | |
| tracing::error!("Max retries exceeeded while waiting for tx {:?} finality.", tx_hash); |
| return Err(eyre!("Max retries exceeeded while waiting for tx {tx_hash} finality.")); | ||
| } | ||
| sleep(duration_to_wait_between_polling).await; | ||
| } else { | ||
| tracing::info!("Tx {tx_hash} has achieved finality"); |
There was a problem hiding this comment.
Suggested change
| tracing::info!("Tx {tx_hash} has achieved finality"); | |
| tracing::info!("Tx {:?} has achieved finality", tx_hash); |
|
Closing in favor of #147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #137.