Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomic create job #152

Merged
merged 7 commits into from
Oct 11, 2024
Merged

atomic create job #152

merged 7 commits into from
Oct 11, 2024

Conversation

apoorvsadana
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 10, 2024

Coverage Status

coverage: 64.899% (+0.5%) from 64.415%
when pulling f9f9025 on automic_create_job
into 1c090fb on main.

Copy link
Member

@ocdbytes ocdbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@heemankv heemankv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

migrations/00000000000000-init.js Show resolved Hide resolved
migrations/00000000000000-init.js Show resolved Hide resolved
@apoorvsadana apoorvsadana merged commit 5fb2de6 into main Oct 11, 2024
9 checks passed
ocdbytes pushed a commit that referenced this pull request Oct 16, 2024
* make create job atomic

* changelog

* comment

* fix prettier

* fix tests and upsert logic

* update: lint fix

---------

Co-authored-by: Heemank Verma <heemankv@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants