move failed jobs to the failed state #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorvsadana
changed the title
Mohiiit
reviewed
Oct 15, 2024
Mohiiit
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed jobs were getting left in
LockedForProcessingstate. This is incorrect, every job should move to a terminal state after everything is done. In this PR, the following changes are doneA failure reason metadata field is added for debugging eventually.
The PR also does an optimisation in update_job which now returns the updated item (vs before where we manually updated the job in the calling function which was hacky)
This PR does NOT fix the issue with jobs being left in
LockedForProcessingwhen an orchestrator pod gets randomly killed. Still need to figure out what to do here.