Fix : snos orch blob data

.env.test

@@ -73,7 +73,7 @@ L1_CORE_CONTRACT_ADDRESS="0xE2Bb56ee936fd6433DC0F6e7e3b8365C906AA057"
 
 ##### SNOS #####
 ## This is needed right now because Madara doesn't support getProof
-RPC_FOR_SNOS=""
+RPC_FOR_SNOS="http://localhost:9944"
 
 
 ##### STARKNET SETTLEMENT #####

CHANGELOG.md

@@ -42,6 +42,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
 ## Changed
 
+- removed error return in case of JobAlreadyExists in `create_job` function
 - update_job returns the updated job item
 - made create_job atomic to avoid race conditions
 - handle jobs in tokio tasks
@@ -68,6 +69,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
 ## Fixed
 
+- blob data formation process from state update
 - OTEL config refactor
 - indexing for get_jobs_without_successor
 - wait for transaction logic in ethereum settlement client

crates/orchestrator/src/jobs/da_job/mod.rs

@@ -400,11 +400,19 @@ fn refactor_state_update(state_update: &mut StateDiff) {
     let addresses_in_storage_diffs: Vec<Felt> =
         state_update.storage_diffs.clone().iter().map(|item| item.address).collect();
 
-    let address_to_insert = find_unique_addresses(addresses_in_nonces, addresses_in_storage_diffs);
+    let address_to_insert = find_unique_addresses(addresses_in_nonces, addresses_in_storage_diffs.clone());
 
     for address in address_to_insert {
         state_update.storage_diffs.push(ContractStorageDiffItem { address, storage_entries: vec![] })
     }
+
+    let addresses_in_deployed_contracts =
+        state_update.deployed_contracts.clone().iter().map(|item| item.address).collect();
+    let addresses_to_insert = find_unique_addresses(addresses_in_deployed_contracts, addresses_in_storage_diffs);
+
+    for address in addresses_to_insert {
+        state_update.storage_diffs.push(ContractStorageDiffItem { address, storage_entries: vec![] })
+    }
 }
 
 fn find_unique_addresses(nonce_addresses: Vec<Felt>, storage_diff_addresses: Vec<Felt>) -> Vec<Felt> {
@@ -486,6 +494,12 @@ pub mod test {
         "src/tests/jobs/da_job/test_data/test_blob/671070.txt",
         "src/tests/jobs/da_job/test_data/nonces/671070.txt"
     )]
+    #[case(
+        178, // Block from pragma madara and orch test run
+        "src/tests/jobs/da_job/test_data/state_update/178.txt",
+        "src/tests/jobs/da_job/test_data/test_blob/178.txt",
+        "src/tests/jobs/da_job/test_data/nonces/178.txt"
+    )]
     #[tokio::test]
     async fn test_state_update_to_blob_data(
         #[case] block_no: u64,

crates/orchestrator/src/jobs/mod.rs

@@ -165,7 +165,8 @@ pub async fn create_job(
 
     // this is technically a redundant check, we've another check inside `create_job`
     if existing_job.is_some() {
-        return Err(JobError::JobAlreadyExists { internal_id, job_type });
+        log::warn!("Job already exists for internal_id {internal_id:?} and job_type {job_type:?}. Skipping!");
+        return Ok(());
     }
 
     let job_handler = factory::get_job_handler(&job_type).await;

crates/orchestrator/src/tests/jobs/da_job/test_data/nonces/178.txt

@@ -0,0 +1,10 @@
+[
+    {
+        "nonce": "0",
+        "address": "2087021424722619777119509474943472645767659996348769578120564519014510906823"
+    },
+    {
+        "nonce": "0",
+        "address": "2227221089168209069826941066512062806409572016263164839237971044383978786453"
+    }
+]

crates/orchestrator/src/tests/jobs/da_job/test_data/state_update/178.txt

@@ -0,0 +1,68 @@
+{
+    "block_hash": "0x385bbbcaada37fbd2be407d02479a86faf632294161451159433f1687afa80a",
+    "old_root": "0x39cc0b3f01d1b4b06a57f1e77d0be8093b9be560380a5b88bc2fefd9932d129",
+    "new_root": "0x249a0f2b937b67ec50021fe7520937d3b8f94564e6d1f935d3b009bbbc45645",
+    "state_diff": {
+        "storage_diffs": [
+            {
+                "address": "0x49d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7",
+                "storage_entries": [
+                    {
+                        "key": "0x68803f24598877e0945e64be0baadefff792986d2c5a2b6e7c8aa334d1c0e52",
+                        "value": "0xf43fc2c03458b02"
+                    },
+                    {
+                        "key": "0x709c6298f62a9011c05499b9f5ccce4ecc3e0753e48096edef484c409c25181",
+                        "value": "0x189f07e"
+                    }
+                ]
+            },
+            {
+                "address": "0x4ec8ffda0fb4db938740a4fa54b3962852b8af5cf323b3d5f6f7ee102258e95",
+                "storage_entries": [
+                    {
+                        "key": "0x2b1577440dd7bedf920cb6de2f9fc6bf7ba98c78c85a3fa1f8311aac95e1759",
+                        "value": "0x7c"
+                    },
+                    {
+                        "key": "0x3b56d7f084d750efc42861fede4548333aff235c695a18e4747698157962a0b",
+                        "value": "0x3c3af083273bcb2bedc6d7f38055d79a"
+                    },
+                    {
+                        "key": "0x3b56d7f084d750efc42861fede4548333aff235c695a18e4747698157962a0a",
+                        "value": "0x3a4ab88085f30eb952f488e972dc0035"
+                    }
+                ]
+            },
+            {
+                "address": "0x1",
+                "storage_entries": [
+                    {
+                        "key": "0xa8",
+                        "value": "0x2ba8421b4e16ae6c77ba5d61446527e4320d2a57465f11147386a3b2f5f7758"
+                    }
+                ]
+            }
+        ],
+        "deprecated_declared_classes": [],
+        "declared_classes": [
+            {
+                "class_hash": "0x29ed6994318833535323c098faa060a20120dc763c281dbe5fb9541a7eaf6c5",
+                "compiled_class_hash": "0xb0ea1eb7b2bbd82380f7b1237ea2fb047719137bf2a7d019dd5e468accc007"
+            }
+        ],
+        "deployed_contracts": [
+            {
+                "address": "0x4220016ed41491dce777cc24efc06a1e88722c3e70506313f504573bce64627",
+                "class_hash": "0x29ed6994318833535323c098faa060a20120dc763c281dbe5fb9541a7eaf6c5"
+            }
+        ],
+        "replaced_classes": [],
+        "nonces": [
+            {
+                "contract_address": "0x4fe5eea46caa0a1f344fafce82b39d66b552f00d3cd12e89073ef4b4ab37860",
+                "nonce": "0xd0"
+            }
+        ]
+    }
+}

crates/orchestrator/src/tests/jobs/mod.rs

@@ -98,10 +98,6 @@ async fn create_job_job_exists_in_db_works() {
     let database_client = services.config.database();
     database_client.create_job(job_item.clone()).await.unwrap();
 
-    assert!(
-        create_job(JobType::ProofCreation, "0".to_string(), HashMap::new(), services.config.clone()).await.is_err()
-    );
-
     // Waiting for 5 secs for message to be passed into the queue
     sleep(Duration::from_secs(5)).await;