Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of Atlantic Service and HTTP Client Infrastructure #182

Merged
merged 49 commits into from
Nov 20, 2024

Conversation

Mohiiit
Copy link
Contributor

@Mohiiit Mohiiit commented Nov 7, 2024

Summary

This PR introduces the Atlantic service integration along with reusable HTTP client infrastructure components.

Changes

  • Integrated Atlantic service for proving capabilities
  • Implemented a generic HTTP client for reusability across services
  • Created a request builder utility for standardized request construction

Technical Details

  • The generic HTTP client provides helper functions that can be reused for future HTTP client implementations
  • Request builder utility simplifies and standardizes the process of creating HTTP requests
  • Atlantic service integration leverages the new HTTP infrastructure

Testing

Test also added for the atlantic service

@Mohiiit Mohiiit changed the title Atlantic Integration Integration of Atlantic Service and HTTP Client Infrastructure Nov 7, 2024
@coveralls
Copy link

coveralls commented Nov 7, 2024

Coverage Status

coverage: 68.127% (+2.0%) from 66.094%
when pulling 3c7bb31 on atlantic_refactor
into 58cca2c on main.

.env.test Outdated Show resolved Hide resolved
crates/orchestrator/src/config.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/tests/config.rs Outdated Show resolved Hide resolved
crates/prover-clients/atlantic-service/Cargo.toml Outdated Show resolved Hide resolved
crates/prover-clients/atlantic-service/src/client.rs Outdated Show resolved Hide resolved
crates/prover-clients/atlantic-service/tests/lib.rs Outdated Show resolved Hide resolved
crates/prover-clients/sharp-service/tests/constants.rs Outdated Show resolved Hide resolved
crates/utils/src/http_client.rs Outdated Show resolved Hide resolved
crates/utils/src/http_client.rs Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
.env.test Outdated Show resolved Hide resolved
crates/orchestrator/src/config.rs Outdated Show resolved Hide resolved
crates/utils/src/http_client.rs Outdated Show resolved Hide resolved
crates/utils/src/http_client.rs Outdated Show resolved Hide resolved
crates/utils/src/http_client.rs Show resolved Hide resolved
crates/utils/src/http_client.rs Outdated Show resolved Hide resolved
crates/utils/src/http_client.rs Outdated Show resolved Hide resolved
crates/utils/src/http_client.rs Show resolved Hide resolved
crates/utils/src/http_client.rs Outdated Show resolved Hide resolved
crates/utils/src/http_client.rs Outdated Show resolved Hide resolved
Copy link
Member

@ocdbytes ocdbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

.env.example Outdated Show resolved Hide resolved
@Mohiiit Mohiiit merged commit 2ab2291 into main Nov 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants