-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): l1<>l2 messaging crate #216
Conversation
Hey @azurwastaken, we were thinking of a different approach about the structure of the code. So instead of creating l1-messaging a different crate, we can have it inside the eth-crate, just like update_state. And as of now we are joining l1_sync with l1_messages_sync and l2_sync, so I was thinking to join l1_sync and l2_sync and inside the l1_sync we will have l1_messages_sync, state_update_sync and l1_gas_price sync, wdyt? so structure of the code we had in mind was:
and the above cc: @cchudant |
Hey @Mohiiit , yes you are right, its porbably better if everything is together |
yes that makes sense also in the future this eth crate will expose a common interface to the rest of the app that is swappable with other chains (e.g for starknet L3s) but i'm getting ahead of myself |
…ed to state_update.rs
…ed to state_update.rs
Outdated, see #220 |
Pull Request type
What is the current behavior?
Resolves: #204
What is the new behavior?
Does this introduce a breaking change?
No
Usefull information
🚨Require #208 🚨
This PR include a lot of code from #208 as we started from it to build with the feature from the eth crate.
A few notes on the current design:
Current Progress
Overall Workflow
Specific case to handle
Tests
E2E test 1
E2E test 2
E2E test 3