-
Notifications
You must be signed in to change notification settings - Fork 71
feat: L3 support #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: L3 support #437
Changes from 26 commits
8949443
abc808e
a49e209
0d6168e
76bc944
75229a4
661cd33
62fb337
d4aa988
a4314be
9dea223
fafd2c3
aa7834e
6c1ff95
26c9319
2a19391
8abf999
749df1c
b63cf61
c837570
1d4d3a4
fffd9dd
71c5524
62d1df3
79ef5ab
8657da3
7afd1a3
c2ba583
885ae41
ab24677
2349d33
545c5b5
704ca2d
8e17399
22e4586
77ad470
a55eb4e
156bd33
911cb87
949826c
46ece21
4cc7b99
4d6ef19
2b9ace3
5664430
b96b091
bdadcda
4d3489e
aee128b
75a5692
039a73b
eb85f68
ecf3f8c
95cadd3
734df0d
b7ddb02
d4fd1a2
9750d43
a45da29
01d8dac
631ac3f
debe4f1
ac13640
2143b56
ea5c455
8f0eb38
180848f
b71fe90
2012d89
9b05b4a
e666be1
5788026
7b25571
afe5413
ae51d7f
640898b
0a2053a
8e13a30
abf0166
caa0f81
df826e8
2c9de51
5fd143c
ecb7dce
9ca71d8
a9b0821
330538d
259c340
5febda7
61bad9c
cc33bd8
ee4c5fe
dc41227
cd0a0a5
edac0fb
5c9de2f
a02fa31
febd3b9
ed07b76
76104f7
227b2f8
87c9421
f623510
d800b75
ba991dc
ce91620
5841945
7702a67
8e7465f
72bfe53
f3c9199
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,24 @@ jobs: | |
- uses: foundry-rs/foundry-toolchain@v1 | ||
with: | ||
version: nightly | ||
- name: Launch Anvil | ||
run: anvil --fork-url $ANVIL_FORK_URL --fork-block-number $ANVIL_BLOCK_NUMBER & | ||
env: | ||
ANVIL_FORK_URL: "https://eth.merkle.io" | ||
ANVIL_BLOCK_NUMBER: 20395662 | ||
- name: Wait for Anvil to be ready | ||
run: | | ||
while ! nc -z localhost 8545; do | ||
sleep 1 | ||
done | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we sure this is necessary? If I remember the rust unit tests should start anvil anyway no? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wouldn't write this in a way where it could be an infinite loop, this would be difficult to debug. At a minimum, a log statement before this (to help when it goes wrong) would help. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi!. Also I'd suggest wrapping this entire logic into a bash script (in |
||
# TODO : For now madara binary is stored in aws s3 bucket : | ||
# After the proper release binaries are implemented | ||
# We can directly use that and we can remove this | ||
# temporary AWS implementation | ||
- name: Download madara binary for l2 client testing | ||
run: | | ||
curl -L https://madara-test-binary.s3.us-west-1.amazonaws.com/madara-linux -o ./test-artifacts/madara | ||
chmod +x ./test-artifacts/madara | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
|
||
- name: Run unit tests | ||
run: | | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
## Next release | ||
|
||
- fix(primitives): limit legacy class sizes | ||
- feat : l3 support | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can remove it |
||
- fix(block_production): dynamic block closing now adds special address with prev block hash | ||
- fix(rpc): call, simulate, estimate rpcs executed on top of the block, not at the start of it | ||
- fix(compilation): crate-level compilation | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
[workspace] | ||
members = [ | ||
# madara | ||
"crates/madara/client/db", | ||
"crates/madara/client/exec", | ||
"crates/madara/client/sync", | ||
"crates/madara/client/eth", | ||
"crates/madara/client/settlement_client", | ||
"crates/madara/client/rpc", | ||
"crates/madara/client/gateway/client", | ||
"crates/madara/client/gateway/server", | ||
|
@@ -31,11 +30,10 @@ members = [ | |
resolver = "2" | ||
# Everything except test-related packages, so that they are not compiled when doing `cargo build`. | ||
default-members = [ | ||
# madara | ||
"crates/madara/client/db", | ||
"crates/madara/client/exec", | ||
"crates/madara/client/sync", | ||
"crates/madara/client/eth", | ||
"crates/madara/client/settlement_client", | ||
"crates/madara/client/gateway/client", | ||
"crates/madara/client/gateway/server", | ||
"crates/madara/client/rpc", | ||
|
@@ -129,7 +127,7 @@ mc-rpc = { path = "crates/madara/client/rpc" } | |
mc-gateway-client = { path = "crates/madara/client/gateway/client" } | ||
mc-gateway-server = { path = "crates/madara/client/gateway/server" } | ||
mc-sync = { path = "crates/madara/client/sync" } | ||
mc-eth = { path = "crates/madara/client/eth" } | ||
mc-settlement-client = { path = "crates/madara/client/settlement_client" } | ||
mc-mempool = { path = "crates/madara/client/mempool" } | ||
mc-block-production = { path = "crates/madara/client/block_production" } | ||
mc-block-import = { path = "crates/madara/client/block_import" } | ||
|
@@ -222,6 +220,7 @@ dotenv = "0.15.0" | |
httpmock = "0.7.0" | ||
tempfile = "3.10.1" | ||
mockall = "0.13.0" | ||
serial_test = "3.1.1" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto |
||
itertools = "0.13.0" | ||
regex = "1.10.5" | ||
bytes = "1.6.0" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we downloading a madara binary for testing instead of running against a build of the code in the pr?