-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(malachite): Tendermint consensus support #477
Draft
Trantorian1
wants to merge
35
commits into
main
Choose a base branch
from
feat/malachite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and refactor the existing stream mapping system
Trantorian1
added
feature
Request for new feature or enhancement
sequencer
Related to the sequencing logic and implementation
node
Related to the full node implementation
research
Research and exploration required before implementation
labels
Jan 24, 2025
Trantorian1
force-pushed
the
feat/malachite
branch
from
February 4, 2025 15:17
25ae91d
to
da9166c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Resolves: #475
Madara currently does not implement any consensus mechanism related to the upcoming Starknet p2p update.
What is the new behavior?
This PR aims to explore the functionality of Malachite and its integration into the codebase in anticipation of #463.
Warning
#463 is required in order for this pr to be merged as it depends on p2p capabilities being added to Madara.
Does this introduce a breaking change?
Yes. Block sync and proposal will be undergoing radical changes.
Other information
Please do not hesitate to give feedback on the early decisions and architecture choices made in this PR. All feedback is welcome!