use unicode to restrict label value space

maddsua · Feb 21, 2025 · 44101a1 · 44101a1
1 parent c00b90b
commit 44101a1
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/service/forwarder/loki/format.go b/service/forwarder/loki/format.go
@@ -2,6 +2,7 @@ package loki
 
 import (
 	"log/slog"
+	"unicode"
 )
 
 func filterLabelFormat(labels map[string]string) {
@@ -76,18 +77,16 @@ func stripLabelValue(key string) string {
 
 	for _, next := range key {
 
-		switch next {
-		case '\\':
+		switch {
+		case next == '\\':
 			stripped += "/"
 			continue
-		}
-
-		if next >= 0x20 && next <= 0x7E {
-			stripped += string(next)
+		case !unicode.IsPrint(next):
+			stripped += "?"
 			continue
 		}
 
-		stripped += "?"
+		stripped += string(next)
 	}
 
 	return stripped