Fix memory management in header-translator
#339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
bug
madsmtm
force-pushed
the
fix-memory-management
branch
2 times, most recently
from
7687dd8
to
8e49fa5
Compare
It is only a hint for clang to do basic liveness analysis.
Which we can't handle just yet
madsmtm
force-pushed
the
fix-memory-management
branch
from
e056d0a
to
819c18e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed by @silvanshade, see #327 (comment) for an explanation of the issue.
This PR fixes the issue, as well as paving the way for supporting the two remaining memory-management attributes that we want to handle;
ns_returns_retainedandns_returns_not_retained.