fix(auth): 🩹 refresh the token only when the API responds 401

maelgangloff · May 4, 2023 · 7943d50 · 7943d50
1 parent 316a916
commit 7943d50
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "scolengo-api",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "types": "types/index.d.ts",
   "homepage": "https://github.com/maelgangloff/scolengo-api#readme",
   "bugs": {

diff --git a/src/index.ts b/src/index.ts
@@ -930,14 +930,18 @@ export class Skolengo {
     try {
       return await this.httpClient.request<T, R, D>(axiosConfig)
     } catch (e) {
-      const error = e as AxiosError<{ errors: SkolengoError[] }, D>
+      const error = e as AxiosError<any>
       const response = error.response
-      if (((response?.data.errors) != null) && (response.data.errors.length > 0)) {
+
+      if (response === undefined || response.status !== 401) throw error
+      if (response.data.errors instanceof Array && response.data.errors.length > 0) {
         throw new SkolengoError(response.data.errors[0])
       }
       const newTokenSet = await this.oidClient.refresh(this.tokenSet)
+
       this.onTokenRefresh(newTokenSet)
       this.tokenSet = newTokenSet
+
       return await this.httpClient.request<T, R, D>({
         ...axiosConfig,
         headers: {