-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yer #751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address comments
client/src/resources/lang/en_us.json
Outdated
"wiki.article.role.yer.abilities":"", | ||
"wiki.article.role.yer.attributes":"", | ||
"wiki.article.role.yer.extra":"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be info here, I'm fairly certain
ControllerParametersMap::new_controller_fast( | ||
game, | ||
ControllerID::role(actor_ref, Role::Yer, 2), | ||
AvailableAbilitySelection::new_role_option( | ||
Role::values().into_iter() | ||
.map(|role| Some(role)) | ||
.collect() | ||
), | ||
AbilitySelection::new_role_option(Some(Role::Yer)), | ||
self.star_passes_remaining <= 0 || !actor_ref.alive(game) || game.day_number() <= 1, | ||
None, | ||
false, | ||
vec_set!(actor_ref) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This always shows I think, even when you haven't chosen to convert. It's fine if this is intentional
No description provided.