Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yer #751

Merged
merged 5 commits into from
Jan 4, 2025
Merged

Yer #751

merged 5 commits into from
Jan 4, 2025

Conversation

ItsSammyM
Copy link
Collaborator

No description provided.

@ItsSammyM ItsSammyM requested a review from Jack-Papel December 31, 2024 20:09
Copy link
Collaborator

@Jack-Papel Jack-Papel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address comments

Comment on lines 1827 to 1829
"wiki.article.role.yer.abilities":"",
"wiki.article.role.yer.attributes":"",
"wiki.article.role.yer.extra":"",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be info here, I'm fairly certain

Comment on lines +110 to +122
ControllerParametersMap::new_controller_fast(
game,
ControllerID::role(actor_ref, Role::Yer, 2),
AvailableAbilitySelection::new_role_option(
Role::values().into_iter()
.map(|role| Some(role))
.collect()
),
AbilitySelection::new_role_option(Some(Role::Yer)),
self.star_passes_remaining <= 0 || !actor_ref.alive(game) || game.day_number() <= 1,
None,
false,
vec_set!(actor_ref)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This always shows I think, even when you haven't chosen to convert. It's fine if this is intentional

@ItsSammyM ItsSammyM merged commit 3ccc559 into main Jan 4, 2025
2 checks passed
@ItsSammyM ItsSammyM deleted the yer branch January 4, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants