Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes radio issues #7

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Vladislav0904
Copy link
Contributor

No description provided.

Now when you are connecting to the server sound enables. When you are disare connecting to the server sound disables.
@Vladislav0904 Vladislav0904 changed the title Fixes radio and sound issues Fixes radio issues Oct 14, 2018
@inlife
Copy link
Member

inlife commented Oct 14, 2018

@Tyldar considering amount of commits and nature of changes, this one is better to be squashed into a single commit i believe

@Segfaultd
Copy link
Member

I'm trying to look if we can replace those lua calls by SDK stuffs yet

@inlife
Copy link
Member

inlife commented Oct 14, 2018

oh sure, if we can that would be even better

@Segfaultd
Copy link
Member

Segfaultd commented Oct 14, 2018

So far, I was able to found those ones :

M2::C_RangeMeter::Get()->OpenSeason(50);
M2::C_SpeechSlotManager::Get()->LoadStage(50);
M2::Wrappers::Radio::SetContent("Empire", "all", "Empire_07010");
M2::Wrappers::Radio::SetContent("Classic", "all", "Classic_07010");
M2::Wrappers::Radio::SetContent("Delta", "all", "Delta_07010");

OpenSeaon is not yet working idk why

Copy link
Member

@Segfaultd Segfaultd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement the sdk version of those calls :D Thank you!

@Segfaultd
Copy link
Member

I've tried and seems that the implementation is crashing. Is it working on ur sides?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants