-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Product Name Metadata to Mage-OS #22
Conversation
For the record: Magento and Adobe Commerce both use: Since the value of |
Note:
|
The Magento2 coding standard violations are present also in the upstream version of the file. |
So Magento currently does not run phpcs on |
I think I'd lean towards option A at the moment, given the infancy of the project and the seeming desire to want to stay as close to 1:1 with the upstream version as possible - at least in the near term. That being said, I have no real preference, personally - I'm happy to go with whatever the general consensus is 🙂 |
I remember seeing somewhere that in upstream |
@sprankhub pointed out this marketplace guide where extensions are checked with error-severity 10 only. |
Once graycoreio/github-actions-magento2#130 is merged, the severity can be configured to 10 and we can move this PR forward. |
Description (*)
Update the product name metadata from
Magento
toMage-OS
.Manual testing scenarios (*)
magento_version
routeMage-OS/*
Contribution checklist (*)