Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Templates #46

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Conversation

pykettk
Copy link
Contributor

@pykettk pykettk commented Oct 8, 2023

Description (*)

Updates the GitHub templates to reference Mage-OS where sensible. Some links or references are unchanged as the Adobe alternatives are more suitable at present.

Manual testing scenarios (*)

  1. Observe the changes in the GitHub template for sensibility

Comments

This was a fairly "brute force" method so if it is preferable to leave certain things as they are, I'm happy to undo those changes. I also wasn't sure if there was a preference for Mage-OS vs Mage-OS Magento. I opted for the latter as I think it's less ambiguous and makes it clear which Mage-OS project we're working with.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@pykettk pykettk requested a review from a team as a code owner October 8, 2023 10:17
Copy link
Contributor

@Vinai Vinai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent :)

@Vinai
Copy link
Contributor

Vinai commented Oct 8, 2023

Sooner or later we need to do the same for all the other mageos-* repos used to build a release.

@Vinai Vinai merged commit 6cb3205 into mage-os:2.4-develop Oct 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants