less intrusive error handling for #12833

magefree · Jan 9, 2025 · 41b9c95 · 41b9c95
1 parent 0c8d49c
commit 41b9c95
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Mage.Client/src/main/java/org/mage/plugins/card/images/DownloadPicturesService.java b/Mage.Client/src/main/java/org/mage/plugins/card/images/DownloadPicturesService.java
@@ -725,8 +725,8 @@ public void run() {
             try {
                 TVFS.umount();
             } catch (FsSyncException e) {
-                logger.fatal("Couldn't unmount zip files " + e, e);
-                MageFrame.getInstance().showErrorDialog("Couldn't unmount zip files " + e, e);
+                logger.error("Couldn't unmount zip files " + e, e);
+                // this is not a critical error - just need to run it again - see issue #12833
             }
         }
 

diff --git a/Mage.Client/src/main/java/org/mage/plugins/card/utils/CardImageUtils.java b/Mage.Client/src/main/java/org/mage/plugins/card/utils/CardImageUtils.java
@@ -185,7 +185,7 @@ public static void checkAndFixImageFiles() {
         try {
             TVFS.umount();
         } catch (FsSyncException e) {
-            LOGGER.fatal("Couldn't unmount zip files on searching broken images " + e, e);
+            LOGGER.error("Couldn't unmount zip files on searching broken images " + e, e);
         }
 
         // real images check is slow, so it used on images download only (not here)