Spy Kit - (Gatherer) (Scryfall) (EDHREC)

{2}
Artifact — Equipment
Equipped creature gets +1/+1 and has all names of nonlegendary creature cards in addition to its name.
Equip {2}

It’s require to refactor “haveSameNames” usage — make sure it used with object param version, no strings only compare in cards/effects/abilities.

Also it’s require to use cache inside new continues effect or object (depends on implementation) — e.g. do not use db requests for creature names search, query/build it only one time on first call and in synchronized method. It’s important cause names compare used all around and must be protected from multiple AI simulations calls (big db queries in AI simulations can eats all memory — searching all names is big query for xmage).

BTW new effect applies to permanent, so no needs to store it in characteristics (e.g. no needs in cards) — permanent can store field like “hasAllCreatureNames” or like that.

Currently, the only way for a MageObject to get more than 2 names at a time is for creatures equipped with Spy Kit, but I think it'd make more sense to have that be supported directly as part of the "names" object itself instead of attached to the card/permanent directly. Should definitely also clean up support for split cards' names. Might not be directly related, but it'd be nice if split cards had images while on the stack (of whichever half has been cast).

Not sure if it's worth the effort, but being theoretically able to support the Unfinity name sticker mechanic might be worth considering in the design of the new name system in case we ever get around to adding that. It is technically Commander-legal, after all.

in response to
Might not be directly related, but it'd be nice if split cards had images while on the stack (of whichever half has been cast).

The code actually works for that currently - just no way from within the client to generate the image files. (I manually created an image file to test.) Same applies for Adventure spells.

I created an issue for this #12910