Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Marchesa, Resolute Monarch's upkeep trigger #12994

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Fix Marchesa, Resolute Monarch's upkeep trigger #12994

merged 2 commits into from
Oct 19, 2024

Conversation

paasar
Copy link
Contributor

@paasar paasar commented Oct 12, 2024 •
edited by xenohedron
Loading

Before fix it was triggering wrongly when player had been dealt damage since last turn.

Fix #12958

@paasar
Fix Marchesa, Resolute Monarch's upkeep trigger
ffe2b3f 
Before fix it was triggering wrongly when player had been dealt damage
since last turn.
@paasar paasar mentioned this pull request Oct 12, 2024
Closed
xenohedron
xenohedron approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@xenohedron xenohedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Always appreciate a clearly written test :)

@xenohedron xenohedron merged commit 3265b9a into magefree:master Oct 19, 2024
4 checks passed
@paasar paasar deleted the fix/marchesa-resolute-monarch branch October 19, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayDi85 JayDi85 JayDi85 left review comments

@xenohedron xenohedron xenohedron approved these changes

Assignees
No one assigned
Labels
cards tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Back side of Invasion of Fiora triggers improperly
3 participants
@paasar @JayDi85 @xenohedron