AbilityPicker Empty Selection Error #13186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-wolf
force-pushed
the
ability-selection-picker-oob
branch
2 times, most recently
from
3894abf to
9115de8
Compare
Do not call objectMouseClicked with an empty selection. Handle selection clamping in a ListSelectionListener. Fixes magefree#13148
johannes-wolf
force-pushed
the
ability-selection-picker-oob
branch
from
9115de8 to
927884e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to remove the selection by holding down CTRL+Draging/Clicking on an item.
This can happen if one wants to hold priority and keeps holding down CTRL while picking an ability.
With this fix, we do not call
objectMouseClickedwith an empty seletction anymore.Changes:
objectMouseClickedwith an empty selectionFont.BOLDinstead of1mouseWheelMovedeventFixes #13148