[DSK] Implement Kaito, Bane of Nightmares #13187
Merged
+184
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackd149
changed the title
|
Part of #12534 |
xenohedron
reviewed
Jan 2, 2025
| } | ||
| } | ||
|
|
||
| enum NumberOfOpponentsWhoLostLife implements DynamicValue { |
There was a problem hiding this comment.
rename to KaitoBaneOfNightmaresCount - we don't use generic class names if they're specific to a single card like this
| return this.calculate(game, sourceAbility.getControllerId()); | ||
| } | ||
|
|
||
| public int calculate(Game game, UUID controllerId) { |
There was a problem hiding this comment.
don't bother with this extra sub method, it's not standard style. Put the logic directly in the overridden method, it's okay that it doesn't use all its params
|
Thanks for the review. I made the changes as requested. |
xenohedron
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Kaito, Bane of Nightmares