Implement [ICE],[ME2] Goblin Ski Patrol

[tiera3]

part of #5382

Original comment - no longer applies

The one (edit - now two) things that aren't quite right is:

• Its controller sacrifices it at the beginning of the next end step.

I used code from Pyric Salamander which states

• Sacrifice Pyric Salamander at the beginning of the next end step.

So I believe that if Goblin Ski Patrol somehow changes controller before the next end step, the new controller wont have to sacrifice it - which they still should.

Edit - now two things. Because ActivateOncePerGameActivatedAbility didn't have the option to apply a condition, I needed to use LimitedTimesPerTurnActivatedAbility instead. This means if Goblin Ski Patrol somehow avoids getting sacrificed at the end of turn, then its ability can be reused in a later turn. (This shouldn't be the case.)

[JayDi85]

[[Goblin Ski Patrol]]

[github-actions]

Goblin Ski Patrol - (Gatherer) (Scryfall) (EDHREC)

{1}{R}
Creature — Goblin
1/1
{1}{R}: Goblin Ski Patrol gets +2/+0 and gains flying. Its controller sacrifices it at the beginning of the next end step. Activate only once and only if you control a snow Mountain.

[JayDi85]

So I believe that if Goblin Ski Patrol somehow changes controller before the next end step, the new controller wont have to sacrifice it - which they still should.

Nope, new controller must sacrifice it. There are oracle text:

Goblin Ski Patrol’s ability may be activated only once in the entire game. If its ability is activated and then it changes controllers, its ability may not be activated again, and its new controller will still have to sacrifice it at the beginning of the End step.
(2008-10-01)

[JayDi85]

Must modify ActivateOncePerGameActivatedAbility to support required conditional

[JayDi85]

Looks like its require small changes in constructor and text generation, activated ability already support condition:

[tiera3]

Found ThoughtShucker uses mage.abilities.decorator.ConditionalActivatedAbility and applies maxActivationsPerGame = 1 so used that method.

Also discovered by reading ArmorOfThorns that a parameter can be passed to SacrificeSourceEffect to require its controller to sacrifice it, so did that also.

fingers crossed This should be right, once I solve the compilation error.

[tiera3]

I wasn't able to get the mage.abilities.decorator.ConditionalActivatedAbility version from ThoughtShucker working, so reverted to original implementation.

[JayDi85]

All must be fine except controlled filter.

[JayDi85]

Must use FilterControlledPermanent as a filter