Revert 291c42f896d0da61125ec654ff6a67a42a8236cd commit#28
Open
ikruchynskyi wants to merge 1 commit intomagento-sparta:masterfrom
Open
Revert 291c42f896d0da61125ec654ff6a67a42a8236cd commit#28ikruchynskyi wants to merge 1 commit intomagento-sparta:masterfrom
ikruchynskyi wants to merge 1 commit intomagento-sparta:masterfrom
Conversation
This reverts commit 291c42f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 291c42f.
Reverts changes which introduced the bug into m2install.sh:
Steps to reproduce:
Actual result:
/usr/local/bin/m2install.sh: line 324: -r: command not foundAs a result m2install will produce output like the next during DB dump restoration:
Expected result:
m2install.sh should be able to determine DB name to run DB dump import without issues.
Link to the failing code line: https://github.com/yvoronoy/m2install/blob/master/m2install.sh#L324