-
Notifications
You must be signed in to change notification settings - Fork 9.4k
getDefaultGroup return type fixed #40084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
getDefaultGroup return type fixed #40084
Conversation
Hi @Plopo23. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
Hi @Plopo23, Thank you for your contribution! Can you please add description and relevant information to the PR in order to proceed further. Thank you! |
Hello @Plopo23, Gentle reminder for sign the CLA and update the PR description. Meanwhile we are moving this PR Thanks |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Plopo23,
Thanks for the contribution!
Please fix the failed static tests, other failed tests seems flaky to me except SVC, we will create an internal JIRA approval ticket.
Thanks
@magento run all tests |
@magento run all tests |
Fixed the static test failures, and for SVC failure, created a approval JIRA. Moving it to Pending Approval, once will get all the required approvals on the JIRA, we will continue further activity on this. |
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)