Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/pwa 3377 after login issue on order success page #4354

Merged

Conversation

del15881
Copy link
Collaborator

@del15881 del15881 commented Nov 19, 2024

Description

This pr Adds the functionality to redirect a guest user to the account-information page when they register an account from the order-confirmation/order-success page.

On login from the order-confirmation/order-success page guest users will be redirected to /order-history page.

Related Issue

https://jira.corp.adobe.com/browse/PWA-3377

Closes #PWA-3377 (https://jira.corp.adobe.com/browse/PWA-3377)

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@del15881 del15881 added enhancement New feature or request version: Minor This changeset includes functionality added in a backwards compatible manner. labels Nov 19, 2024
@del15881 del15881 self-assigned this Nov 19, 2024
@del15881 del15881 requested a review from glo82145 November 19, 2024 17:42
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Nov 19, 2024

Messages
📖

Associated JIRA tickets: PWA-3377.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against b53c5c5

glo82145
glo82145 previously approved these changes Nov 22, 2024
@glo82145
Copy link
Collaborator

run scaffold-pwa

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 22, 2024

Successfully started codebuild job for scaffold-pwa

// Return an empty response if no valid order or shipping address exists
return;

//Below code can be uncommented in case of wanting to show the order success page with blank shipping address.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these commented lines

@glo42707
Copy link
Contributor

glo42707 commented Dec 9, 2024

run code-build

Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@glo42707 glo42707 merged commit 1f39b61 into develop Dec 9, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg:peregrine pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants