Skip to content

Conversation

@del15881
Copy link
Collaborator

Description

Fix issues with 404 page rendering.
TODO: Describe your changes in detail here.

Related Issue

https://jira.corp.adobe.com/browse/PWA-3589

Closes #PWA-3589.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@del15881 del15881 added the version: Patch This changeset includes backwards compatible bug fixes. label Sep 29, 2025
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 29, 2025

Fails
🚫

node failed.

Log

Error: Error: Cannot find module './.lighthouseci/assertion-results.json'
Require stack:
- dangerfile.lighthouse.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/runner/runners/inline.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/commands/danger-runner.js

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-dad275cd.json

Generated by 🚫 dangerJS against 1029390

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 29, 2025

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 1029390

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 29, 2025

Fails
🚫 Missing information in PR. Please fill out the "Description" section.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖

Associated JIRA tickets: PWA-3589.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 1029390

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 29, 2025

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • displays assigned products:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CategoryContent-root"] [data-cy="GalleryItem-name"], [data-cy="SearchPage-root"] [data-cy="GalleryItem-name"]`, but never found it.
    ,shows products specific to the categories in the different store:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CategoryContent-root"] [data-cy="GalleryItem-name"], [data-cy="SearchPage-root"] [data-cy="GalleryItem-name"]`, but never found it.
    ,lets users add products to cart regardless of store view:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CategoryContent-root"] [data-cy="GalleryItem-root"]`, but never found it.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 1029390

@glo82145 glo82145 self-requested a review September 30, 2025 07:20
@del22123 del22123 merged commit af3ce24 into release/14.4.0 Sep 30, 2025
6 of 13 checks passed
@del22123 del22123 deleted the PWA-3589 branch September 30, 2025 08:42
glo82145 added a commit that referenced this pull request Oct 15, 2025
* Sync main 14.3.1 (#4533)

* v14.3.1-alpha1

* Merge pull request #4525 from magento/patch/npm-access-update-live-search

Adding Public Access to publish to NPM

* v14.3.1-alpha12

* v14.3.1-beta1

* PWA-14.3.1 release notes (#4530)

* PWA-14.3.1 release notes (#4531)

* Update magento-compatibility.js (#4532)

* v14.3.1

---------

Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>
Co-authored-by: Ilesh Tiwari <del15881@adobe.com>

* PWA-3536: Removed package-lock.json (#4535)

* PWA-3463: Supressing noisy warnings on Select (#4505)

* PWA-4468: use the same version of `react-tabs` everywhere (#4469)

* Prevent Cart Creation for Guest User and Add Functionality To Create … (#4537)

* Prevent Cart Creation for Guest User and Add Functionality To Create Cart only when Guest User Adds Product to Cart

* Fixing Prettier and Snapshot test cases

* Removing unwanted and commented out code

* PWA-3576::Video component issue in dynamic CMS block (#4541)

* PWA-3576::Video component issue in dynamic CMS block

* PWA-3576::Video component issue in dynamic CMS block

* PWA-3537: Fixed out of saleable stock issue in PDP and cart edit pop up (#4540)

* PWA-3534:Fixed wishlist pagination issue (#4542)

* Remove useCustomerWishlistSkus hook from Carousel and Gallery components and add in useApp talon to avoid infinite loop (#4543)

Co-authored-by: Jose Amietta <joseamietta@gmail.com>

* PWA-3583: Fixed search page-clear filter customer issue (#4544)

* Fixing Wishlist Failing Test Cases originating from PR ID : 4543 (#4547)

* Enhancement/pwa 3550 (#4545)

* Prevent Cart Creation for Guest User and Add Functionality To Create Cart only when Guest User Adds Product to Cart

* Fixing Prettier and Snapshot test cases

* Removing unwanted and commented out code

* Handle Cart Creation and Merging for the Logged In users

* Adding Logic To create a Cart when Products added to cart from wishlist Page

* Fixing all the Failing Test cases related to Wishlist

* Fixing Failing Test Cases for ADD TO CART Dialog box

* Fixing Cart related test cases

* PWA-3538::nvalid auth middleware clearTimeout implementation (#4550)

* PWA-3542:Fixed upward path issue (#4549)

Co-authored-by: glo82145 <glo82145@adobe.com>

* PWA-3361:Multi store CSP fix (#4548)

Co-authored-by: glo82145 <glo82145@adobe.com>

* PWA-3610: Fixed targetables call (#4558)

* Fixing 404 Rendering Issue (#4556)

Co-authored-by: Bharathidasan Elangovan <del22123@adobe.com>

* v14.4.0-alpha2

* v14.4.0-alpha3

* Pwa 3610 v2 (#4559)

* PWA-3610: Fixed targetables call

* PWA-3610: Fixed targetables call

* v14.4.0-alpha5

* v14.4.0-alpha6

* Fixing the Issues with Targetables on Release blocker (#4561)

* Fixing the Issues with Targetables on Release blocker

* Fixing Prettier Issues

* v14.4.0-alpha10

* v14.4.0-alpha11

* PWA-3613: RI-Wishlist pagination fix (#4562)

* PWA-3613: RI-Wishlist pagination fix

* PWA-3613:Fixed lint and prettier issues

---------

Co-authored-by: Bharathidasan Elangovan <del22123@adobe.com>

* v14.4.0-alpha12

* v14.4.0-beta1

* Pwa 14.4.0 changelog (#4564)

* PWA-3610: Fixed targetables call

* PWA-14.4.0 - Change log

* PWA-14.4.0 - Change log

* PWA-14.4.0 - Change log

* PWA-14.4.0 - Change log

* Pwa 14.4.0 resolve conflicts (#4565)

* PWA-3610: Fixed targetables call

* PWA-14.4.0 - Change log

* Pwa 14.4.0 releaseconflicts v1 (#4566)

* PWA-3610: Fixed targetables call

* PWA-14.4.0 - Change log

* PWA-14.4.0 - Change log

* PWA-14.4.0 - Change log

* v14.4.0-beta2

* v14.4.0-beta3

---------

Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>
Co-authored-by: Ilesh Tiwari <del15881@adobe.com>
Co-authored-by: Bharathidasan Elangovan <del22123@adobe.com>
Co-authored-by: Brendan Falkowski <brendan@gravitydept.com>
Co-authored-by: Jose Amietta <joseamietta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:peregrine version: Patch This changeset includes backwards compatible bug fixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants