Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move permission for Two Factor Auth to top #338

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

amenk
Copy link

@amenk amenk commented Aug 16, 2024

Fix: As a restricted user I want to be able to setup and login using TFA, without seeing an empty System -> Permissions menu

Description (*)

We have very restricted users who can only see a sales menu; now they should be able to use TFA which needs the Magento_TwoFactorAuth::tfa permission. But this would require to also see the system menu

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. give only a sales order menu and "Use Two Factor Auth" permission
  2. login using TFA, see only the sales menu

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Fix: As a restricted user I want to be able to setup and login using TFA, without seeing an empty System -> Permissions menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant