Fix Age Config Defaults and Operation #4444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsuta
reviewed
Feb 7, 2025
uber/configspec.ini
Outdated
| @@ -1392,7 +1392,7 @@ can_volunteer = boolean(default=True) | |||
| consent_form = boolean(default=False) | |||
|
|
|||
| [[under_13]] | |||
There was a problem hiding this comment.
Let's simplify these a bit more, since not all conventions have the under-13/over-13 distinction, and just do two age groups: under 18 and 18 and up. The wristband color can be red vs green and the under-18 group should have volunteering turned off and the consent form turned on.
kitsuta
reviewed
Feb 8, 2025
uber/configspec.ini
Outdated
| [[under_13]] | ||
| desc = string(default="Between 6 and 13") | ||
| [[under_18]] | ||
| desc = string(default="Under 18") | ||
| min_age = integer(default=6) |
There was a problem hiding this comment.
Min age should be 0 here so people under 6 don't get sorted into "age unknown"
There was a problem hiding this comment.
fixed. i didnt realize there wasn't a min age config elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets try this again with a new branch name....
Sets collect birthdays to true
Restores ability to have age categories
Sets up some sane (?) defaults in age categories