buildAndPushRelease should have (non-default) pause before assembleRelease #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lease to avoid timeout on pinentry if RM steps away from the build machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apache#1125 works around gpg pinentry via a
setup_gpgstep that caches the user pin ingpg-agent.For configurations that require explicit user PIN entry via non-tty-based pinentry program, as discussed in help/publishing.txt -- i.e., where gpg-agent is not configured to cache user PIN -- the approach followed in apache#1125 will not work.
In such cases, we should provide the option to pause for user confirmation before proceeding to the
assembleRelease/signing phase. Without such a pause, it's likely that an RM will step away while tests are running, and once tests complete but before the RM returns, the pinentry prompt will timeout, causing the entire invocation ofbuildAndPushRelease.pyto fail unnecessarily (ask me how I know 😁).This PR, if merged to upstream Solr, should ideally be merged after apache#1289 (or analogous PR against
mainbranch).