Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ Entities extra_seed should be bytes rather than an optional string, to avoid issues with encoding/decoding #86

Merged
merged 1 commit into from
Oct 29, 2024
Merged

feat: ✨ Entities extra_seed should be bytes rather than an optional string, to avoid issues with encoding/decoding #86

merged 1 commit into from
Oct 29, 2024

Conversation

iamnamananand996
Copy link
Contributor

@iamnamananand996 iamnamananand996 commented Oct 12, 2024 •
edited by GabrielePicco
Loading

Status Type ⚠️ Core Change Issue
Ready Feature Yes #48

Problem

  • Entities extra_seed should be bytes rather than an optional string, to avoid issues with encoding/decoding

Solution

@iamnamananand996 iamnamananand996 changed the title feat: ✨ Entities extra_seed should be bytes rather than an o… feat: ✨ Entities extra_seed should be bytes rather than an optional string, to avoid issues with encoding/decoding Oct 12, 2024
@GabrielePicco GabrielePicco force-pushed the entities-extra_seed-should-be-bytes-rather-than-an-optional-string,-to-avoid-issues-with-encoding/decoding branch from 42540ee to 2383818 Compare October 16, 2024 10:19
GabrielePicco
GabrielePicco approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@GabrielePicco GabrielePicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM!

@GabrielePicco GabrielePicco merged commit 1bad82f into magicblock-labs:main Oct 29, 2024
4 checks passed
@GabrielePicco GabrielePicco mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielePicco GabrielePicco GabrielePicco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entities extra_seed should be bytes rather than an optional string, to avoid issues with encoding/decoding
2 participants
@iamnamananand996 @GabrielePicco