Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get scaled traces for SpikeSortingView #231

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

khl02007
Copy link
Contributor

@khl02007 khl02007 commented Jul 9, 2024

Sometimes the spikeinterface recording object is in analog-to-digital converter units rather than physically meaningful units like microvolts. In that case, the recording may have gain parameters that can be applied during calls to get_traces to convert the traces to physical units. This change checks if such parameters exist (by calling either has_scaleable_traces or has_scaled methods) and sets return_scaled parameter of get_traces to that.

@magland
Copy link
Owner

magland commented Jul 9, 2024

@khl02007 I'm fine merging this as long as you've tested it on your end.

@khl02007
Copy link
Contributor Author

Just tried running my branch on two recording objects, one with scale specified and one without. It seems they both run and are the same except for the scale in the spike amplitude view

@alejoe91
Copy link
Collaborator

Looks good to me too @khl02007

@magland magland merged commit b05ecba into magland:main Jul 10, 2024
1 check passed
@magland
Copy link
Owner

magland commented Jul 10, 2024

Now published as 0.13.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants