Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix fader GHG emission pricing policy and Sync of NPI and NDC policies to 2025 #755

Merged
merged 12 commits into from
Dec 3, 2024

Conversation

flohump
Copy link
Contributor

@flohump flohump commented Nov 29, 2024

🐦 Description of this PR 🐦

This PR fixes the GHG emission pricing policy fader. The target year s56_fader_end was not used in the time interpolation.
In addition, the NPI and NPC policies are synched until 2025

  • 56_ghg_policy Fader for GHG emission pricing policy
  • scripts NPI/NDC policies synced to the year 2025 - update of additional data to additional_data_rev4.59.tgz
  • 56_ghg_policy added new interface pcm_carbon_stock to avoid use of vm_carbon_stock.l in equations
  • config settings in default.cfg for some switches in 73_timber did not work correctly
  • modules renamed country_dummy to country_switch in all modules

🔧 Checklist for PR creator 🔧

  • Label pull request from the label list.

    • Low risk: Simple bugfixes (missing files, updated documentation, typos) or changes in start or output scripts
    • Medium risk: Uncritical changes in the model core (e.g. moderate modifications in non-default realizations)
    • High risk: Critical changes in model core or default settings (e.g. changing a model default or adjusting a core mechanic in the model)
  • Self-review own code

    • No hard coded numbers and cluster/country/region names.
    • The new code doesn't contain declared but unused parameters or variables.
    • magpie4 R library has been updated accordingly and backwards compatible where necessary.
    • scenario_config.csv has been updated accordingly (important if default.cfg has been updated)
  • Document changes

    • Add changes to CHANGELOG.md
    • Where relevant, put In-code documentation comments
    • Properly address updates in interfaces in the module documentations
    • run goxygen::goxygen() and verify the modified code is properly documented
  • Perform test runs

    • Low risk:
      • Run a compilation check via Rscript start.R --> "compilation check"
    • Medium risk:
      • Run test runs via Rscript start.R --> "test runs"
      • Check logs for errors/warnings
    • High risk:
      • Run test runs via Rscript start.R --> "test runs"
      • Check logs for errors/warnings
      • Default run from the PR target branch for comparison
      • Provide relevant comparison plots (land-use, emissions, food prices, land-use intensity,...)

📉 Performance changes 📈

  • Current develop branch default : ** mins
  • This PR's default : ** mins

🚨 Checklist for reviewer 🚨

  • PR is labeled correctly
  • Code changes look reasonable
    • No hard coded numbers and cluster/country/region names.
    • No unnecessary increase in module interfaces
    • model behavior/performance is satisfactory.
  • Changes are properly documented
    • CHANGELOG is updated correctly
    • Updates in interfaces have been properly addressed in the module documentations
    • In-code documentation looks appropriate
  • content review done (at least 1)
  • RSE review done (at least 1)

[MS] In addition, the PR includes syncing of landuse NPI and NDC policies to the year 2025. So far, NPI had targets in 2020, which was also the starting year for NDCs. The issues was that (coupled)runs were diverging after 2020 in scenarios with NPI and NDC, while there is need to have them historically synced. The change moves target year for NPIs to 2025, however as this wasn't clear in documentation, an assumption was made of an approximate target for NPI in 2025 based on a progress needed to reach NDC in 2030 (usually the target year for landuse NDCs).

Some noticeable changes in the results are related mainly to forest cover, i.e. the NPI-NDC based afforestation.

image

The NPI pathway is higher than previously. This is due to setting a target year in NPI implementation to 2025, and given that we interpolate over the policy period, it shows higher rates of afforestation than before.
Main changes are noticeable for China, which has anyway the highest afforestation ambition. The new implementation improves of forest validation for China:
image

Emissions are plausible:
image

@flohump flohump added Minor Smaller modifications bugfix labels Nov 29, 2024
@flohump flohump added the Low risk Low risk label Nov 29, 2024
Copy link
Contributor

@mishkos mishkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

flohump and others added 5 commits December 2, 2024 09:38
new additional_data version with upgraded npi_ndc policy settings.
syncing npi and ndc policies to year 2025.
@mishkos mishkos changed the title bugfix fader GHG emission pricing policy bugfix fader GHG emission pricing policy and Sync of NPI and NDC policies to 2025 Dec 2, 2024
Copy link
Member

@FelicitasBeier FelicitasBeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a question to where the roundwood and woodfuel costs come from. Maybe a reference could be added in the default.cfg so that this is clearer

# * (inflated from default originally in USD05 using USD05 --> USD17 inflation rate: 1.23)
s73_timber_prod_cost <- 2460 # def = 2000 * 1.23
cfg$gms$s73_timber_prod_cost_wood <- 148 # def = 120 * 1.23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do the original values come from? Maybe add a reference for the 120 for roundwood and 60 for woodfuel in the comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of 2460 was never used because cfg$gms was missing in front of s73_timber_prod_cost. Moreover, s73_timber_prod_cost does no longer exist.
The value of s73_timber_prod_cost_wood is unchanged because so far the value was directly taken from input.gms

@FelicitasBeier
Copy link
Member

The fact that the woodfuel cost and the roundwood price have changed in the default.cfg hasn't been mentioned in the changelog. Maybe good to mention it there?

@flohump flohump merged commit 66d69ab into magpiemodel:develop Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Low risk Low risk Minor Smaller modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants