-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix fader GHG emission pricing policy and Sync of NPI and NDC policies to 2025 #755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
new additional_data version with upgraded npi_ndc policy settings.
syncing npi and ndc policies to year 2025.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a question to where the roundwood and woodfuel costs come from. Maybe a reference could be added in the default.cfg so that this is clearer
# * (inflated from default originally in USD05 using USD05 --> USD17 inflation rate: 1.23) | ||
s73_timber_prod_cost <- 2460 # def = 2000 * 1.23 | ||
cfg$gms$s73_timber_prod_cost_wood <- 148 # def = 120 * 1.23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do the original values come from? Maybe add a reference for the 120 for roundwood and 60 for woodfuel in the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of 2460 was never used because cfg$gms
was missing in front of s73_timber_prod_cost. Moreover, s73_timber_prod_cost
does no longer exist.
The value of s73_timber_prod_cost_wood
is unchanged because so far the value was directly taken from input.gms
The fact that the woodfuel cost and the roundwood price have changed in the default.cfg hasn't been mentioned in the changelog. Maybe good to mention it there? |
🐦 Description of this PR 🐦
This PR fixes the GHG emission pricing policy fader. The target year
s56_fader_end
was not used in the time interpolation.In addition, the NPI and NPC policies are synched until 2025
additional_data_rev4.59.tgz
73_timber
did not work correctlycountry_dummy
tocountry_switch
in all modules🔧 Checklist for PR creator 🔧
Label pull request from the label list.
Self-review own code
magpie4
R library has been updated accordingly and backwards compatible where necessary.scenario_config.csv
has been updated accordingly (important ifdefault.cfg
has been updated)Document changes
CHANGELOG.md
goxygen::goxygen()
and verify the modified code is properly documentedPerform test runs
Rscript start.R --> "compilation check"
Rscript start.R --> "test runs"
Rscript start.R --> "test runs"
📉 Performance changes 📈
🚨 Checklist for reviewer 🚨
CHANGELOG
is updated correctly[MS] In addition, the PR includes syncing of landuse NPI and NDC policies to the year 2025. So far, NPI had targets in 2020, which was also the starting year for NDCs. The issues was that (coupled)runs were diverging after 2020 in scenarios with NPI and NDC, while there is need to have them historically synced. The change moves target year for NPIs to 2025, however as this wasn't clear in documentation, an assumption was made of an approximate target for NPI in 2025 based on a progress needed to reach NDC in 2030 (usually the target year for landuse NDCs).
Some noticeable changes in the results are related mainly to forest cover, i.e. the NPI-NDC based afforestation.
The NPI pathway is higher than previously. This is due to setting a target year in NPI implementation to 2025, and given that we interpolate over the policy period, it shows higher rates of afforestation than before.

Main changes are noticeable for China, which has anyway the highest afforestation ambition. The new implementation improves of forest validation for China:
Emissions are plausible:
