cleanup

CHANGELOG.md

@@ -16,7 +16,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 -
 
 ### fixed
--
+- **44_biodiversity** bugfix i44_biome_share, code cleanup, added scaling of `q44_bii`
 
 ## [4.9.0] - 2024-12-05
 

modules/44_biodiversity/bii_target/declarations.gms

@@ -16,7 +16,6 @@ positive variables
 parameters
  p44_bii_lower_bound(t,i,biome44) Interpolated lower bound for BII over time (1)
  p44_start_value(i,biome44)       Start value for BII lower bound (1)
- p44_target_value(i,biome44)      Target value for BII lower bound (1)
  i44_biome_share(j,biome44)       Share of biome type in each spatial unit (1)
  i44_biome_area_reg(i,biome44)    Area of range-rarity weighted biome type in each region (mio. ha)
 ;

modules/44_biodiversity/bii_target/equations.gms

@@ -13,13 +13,13 @@
  q44_bii(i2,biome44)$(i44_biome_area_reg(i2,biome44) > 0) .. 
           v44_bii(i2,biome44)
           =e=
-          sum((cell(i2,j2),potnatveg,landcover44), vm_bv(j2,landcover44,potnatveg) * i44_biome_share(j2,biome44))
+          sum((cell(i2,j2),landcover44,potnatveg), vm_bv(j2,landcover44,potnatveg) * i44_biome_share(j2,biome44))
           / i44_biome_area_reg(i2,biome44);
 
 *' For each of the 71 biomes, the BII has to meet a minium level based on `s44_bii_lower_bound`.
 *' `v44_bii_missing` is a technical variable to maintain feasibility in case `v44_bii` cannot be increased.
 
- q44_bii_target(i2,biome44)$(i44_biome_area_reg(i2,biome44) > 0) ..          
+ q44_bii_target(i2,biome44) ..          
           v44_bii(i2,biome44) + v44_bii_missing(i2,biome44) =g= sum(ct, p44_bii_lower_bound(ct,i2,biome44));
 
 *' Costs accrue only for `v44_bii_missing`. In the best case costs should be zero or close to zero.

modules/44_biodiversity/bii_target/preloop.gms

@@ -1,16 +1,17 @@
-*** |  (C) 2008-2024 Potsdam Institute for Climate Impact Research (PIK)
+*** |  (C) 2008-2023 Potsdam Institute for Climate Impact Research (PIK)
 *** |  authors, and contributors see CITATION.cff file. This file is part
 *** |  of MAgPIE and licensed under AGPL-3.0-or-later. Under Section 7 of
 *** |  AGPL-3.0, you are granted additional permissions described in the
 *** |  MAgPIE License Exception, version 1.0 (see LICENSE file).
 *** |  Contact: magpie@pik-potsdam.de
 
 * Calculate biome share
-i44_biome_share(j,biome44) = 
-   (f44_biome_area(j,biome44) + 1e-10) / sum(biome44_2, f44_biome_area(j,biome44_2) + 1e-10);
+i44_biome_share(j,biome44) = 0;
+i44_biome_share(j,biome44)$(sum(biome44_2, f44_biome_area(j,biome44_2)) > 0) = 
+   f44_biome_area(j,biome44) / sum(biome44_2, f44_biome_area(j,biome44_2));
 
 * Set i44_biome_area_reg
 i44_biome_area_reg(i,biome44) = 
-  sum((cell(i,j),land), pcm_land(j,land) * i44_biome_share(j,biome44));
+  sum((cell(i,j),land), pcm_land(j,land) * f44_rr_layer(j) * i44_biome_share(j,biome44));
 
 p44_bii_lower_bound(t,i,biome44) = 0;

modules/44_biodiversity/bii_target/presolve.gms

@@ -1,4 +1,4 @@
-*** |  (C) 2008-2024 Potsdam Institute for Climate Impact Research (PIK)
+*** |  (C) 2008-2023 Potsdam Institute for Climate Impact Research (PIK)
 *** |  authors, and contributors see CITATION.cff file. This file is part
 *** |  of MAgPIE and licensed under AGPL-3.0-or-later. Under Section 7 of
 *** |  AGPL-3.0, you are granted additional permissions described in the
@@ -13,32 +13,31 @@ loop(i,
       v44_bii_missing.fx(i,biome44) = 0;
     else
       v44_bii.l(i,biome44) = 
-        sum((cell(i,j),potnatveg,landcover44), vm_bv.l(j,landcover44,potnatveg) * i44_biome_share(j,biome44))
+        sum((cell(i,j),landcover44,potnatveg), vm_bv.l(j,landcover44,potnatveg) * f44_rr_layer(j) * i44_biome_share(j,biome44))
         / i44_biome_area_reg(i,biome44);
     );
   );
 );
 
+if (m_year(t) = s44_start_year AND s44_bii_lower_bound > 0,
 * The start value for the linear interpolation is the BII at biome level in the start year.
-p44_start_value(i,biome44)$(m_year(t) = s44_start_year) = v44_bii.l(i,biome44);
+  p44_start_value(i,biome44) = v44_bii.l(i,biome44);
 * The target value for the linear interpolation is the lower bound defined in `s44_bii_lower_bound`.
-p44_target_value(i,biome44) = s44_bii_lower_bound;
+* Linear increase of BII target values at biome level from start year to target year, and constant values thereafter.
+  p44_bii_lower_bound(t2,i,biome44) = p44_start_value(i,biome44) + ((m_year(t2) - s44_start_year) / (s44_target_year - s44_start_year)) * (s44_bii_lower_bound - p44_start_value(i,biome44));
+  p44_bii_lower_bound(t2,i,biome44)$(m_year(t2) > s44_target_year) = s44_bii_lower_bound;
+* Avoid implausible values
+  p44_bii_lower_bound(t2,i,biome44)$(p44_bii_lower_bound(t2,i,biome44) >= 1) = 1;
+  p44_bii_lower_bound(t2,i,biome44)$(m_year(t2) < s44_start_year) = 0;
+  p44_bii_lower_bound(t2,i,biome44)$(i44_biome_area_reg(i,biome44) <= 0) = 0;
+);
 
 if (m_year(t) <= sm_fix_SSP2,
  v44_bii.lo(i,biome44) = 0;
 else
-* Linear increase of BII target values at biome level from start year to target year, and constant values thereafter.
-  p44_bii_lower_bound(t2,i,biome44) = p44_start_value(i,biome44) + ((m_year(t2) - s44_start_year) / (s44_target_year - s44_start_year)) * (p44_target_value(i,biome44) - p44_start_value(i,biome44));
-  p44_bii_lower_bound(t2,i,biome44)$(m_year(t2) > s44_target_year) = p44_target_value(i,biome44);
+  v44_bii.lo(i,biome44) = p44_bii_lower_bound(t,i,biome44);
   if(c44_bii_decrease = 0,
-    p44_bii_lower_bound(t,i,biome44)$(v44_bii.l(i,biome44) >= p44_target_value(i,biome44)) = v44_bii.l(i,biome44);   
-  elseif c44_bii_decrease = 1,
-    p44_bii_lower_bound(t,i,biome44)$(v44_bii.l(i,biome44) >= p44_target_value(i,biome44)) = p44_target_value(i,biome44);
+    v44_bii.lo(i,biome44)$(v44_bii.l(i,biome44) >= s44_bii_lower_bound) = v44_bii.l(i,biome44);   
   );
-  p44_bii_lower_bound(t,i,biome44)$(p44_bii_lower_bound(t,i,biome44) >= 1) = 1;
-  p44_bii_lower_bound(t,i,biome44)$(m_year(t) < s44_start_year) = 0;
-  p44_bii_lower_bound(t,i,biome44)$(i44_biome_area_reg(i,biome44) <= 0) = 0;
-* The lower bound of `v44_bii` is set to `p44_bii_lower_bound` to avoid a reduction of BII in combination with `v44_bii_missing`.
-  v44_bii.lo(i,biome44) = p44_bii_lower_bound(t,i,biome44);
-  display p44_bii_lower_bound;
 );
+

modules/44_biodiversity/bii_target/realization.gms

@@ -19,6 +19,7 @@ $Ifi "%phase%" == "sets" $include "./modules/44_biodiversity/bii_target/sets.gms
 $Ifi "%phase%" == "declarations" $include "./modules/44_biodiversity/bii_target/declarations.gms"
 $Ifi "%phase%" == "input" $include "./modules/44_biodiversity/bii_target/input.gms"
 $Ifi "%phase%" == "equations" $include "./modules/44_biodiversity/bii_target/equations.gms"
+$Ifi "%phase%" == "scaling" $include "./modules/44_biodiversity/bii_target/scaling.gms"
 $Ifi "%phase%" == "preloop" $include "./modules/44_biodiversity/bii_target/preloop.gms"
 $Ifi "%phase%" == "presolve" $include "./modules/44_biodiversity/bii_target/presolve.gms"
 $Ifi "%phase%" == "postsolve" $include "./modules/44_biodiversity/bii_target/postsolve.gms"

modules/44_biodiversity/bii_target/scaling.gms

@@ -0,0 +1,8 @@
+*** |  (C) 2008-2024 Potsdam Institute for Climate Impact Research (PIK)
+*** |  authors, and contributors see CITATION.cff file. This file is part
+*** |  of MAgPIE and licensed under AGPL-3.0-or-later. Under Section 7 of
+*** |  AGPL-3.0, you are granted additional permissions described in the
+*** |  MAgPIE License Exception, version 1.0 (see LICENSE file).
+*** |  Contact: magpie@pik-potsdam.de
+
+q44_bii.scale(i,biome44) = 1e10;