Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appointment feature #9

Merged
merged 12 commits into from
Feb 13, 2024
Merged

Appointment feature #9

merged 12 commits into from
Feb 13, 2024

Conversation

Uzair-Manzoor
Copy link
Collaborator

@Uzair-Manzoor Uzair-Manzoor commented Feb 12, 2024

This PR has been created against below mentioned implementations into the project:

  • added the form for booking an appointment
  • added my appointments page
  • fixed linters

Copy link
Owner

@mahdinoori2000 mahdinoori2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Uzair-Manzoor ,

Great job so far! 👏 You've done well, and you're almost there for the next project ⏭️, but there are a few issues 🐛 that you still need to work on.

Highlights

✅ Great UI
✅ Clean Code

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

-[ ] Kindly ensure that add the dependencies in the PR description that you installed in the branch. It's a best practice.

Comment on lines +27 to +29
// Ensure fetchedDoctors is initialized as an array
const fetchedDoctors = useSelector((state) => state.doctors.doctors) || [];

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing the appointment booking feature. However, I noticed that when attempting to book an appointment, the doctor's name isn't displayed. Could you please address this issue?

now showing doctor

Comment on lines +5 to +13
const createAppointment = createAsyncThunk('user/createAppointment', async (data) => {
try {
const response = await fetch(url, {
method: 'POST',
headers: {
'Content-Type': 'application/json',
Authorization: `Bearer ${JSON.parse(localStorage.getItem('user'))?.token}`,
},
body: JSON.stringify(data),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered a 404 error when attempting to submit an appointment. It seems to be originating from the slice. Could you please investigate and resolve this issue?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mahdinoori2000 , thanks for your feedback. I'm working to fix the addressed issues 😭

@ismayito ismayito merged commit aedd601 into dev Feb 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants