-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove httpx
's deprecated parameter proxies
#231
Conversation
(soft-removed with new exception raising)
Removing proxy is not a good idea , #230 is about httpx httpx.Client(proxy='socks5://user:pass@host:port') |
According to my study, currently tweety only use
|
🤔 I think you are right, https://github.com/encode/httpx/releases/tag/0.26.0 says
And encode/httpx#2879 provided complete example code:
|
Also need to make sure proxy is in correct format ProxyTypes = Union["URL", str, "Proxy"] |
@mahrtayyab Done, check with changchiyou/wildrift-news-feeds@4472a6d |
Fix #230:
I can't find any usecase / demo with
proxies
parameter from docs, and it has already deprecated httpx. I think it's time to remove it from project.