This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
chore: remove network contacts from peer acquisition #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of this feature caused the node manager to return a peer list from the default network contacts file that is uploaded to S3, which doesn't really make sense for the node manager. Now, if no `--peer` argument is supplied, the node manager will handle an error from the peer acquisition crate by using an `unwrap_or` and return an empty peer list. This supports a genesis node scenario where no peers should be supplied.
b-zee
approved these changes
Dec 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of this feature caused the node manager to return a peer list from the default network contacts file that is uploaded to S3, which doesn't really make sense for the node manager.
Now, if no
--peerargument is supplied, the node manager will handle an error from the peer acquisition crate by using anunwrap_orand return an empty peer list. This supports a genesis node scenario where no peers should be supplied.