This repository was archived by the owner on Jan 25, 2024. It is now read-only.
feat: provide run command
#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-zee
approved these changes
Dec 19, 2023
NOTE: this commit also contains the corresponding `kill` command. I accidentally amended it and couldn't untangle the changes from it without losing them. Spin up `safenode` processes, along with a faucet, to run a local network. These processes are not defined as services because they are not intended to be long running; they are for experimentation. As in the `testnet` binary, the network is validated, but unlike in `testnet` the logs are not inspected. We just query each RPC service to check that peers are connected. At present you need to supply paths to both binaries, but this will be extended shortly to provide the ability to run downloaded binaries. The node registry was extended to keep track of the faucet process so it can easily be cleaned up in a subsequent `kill` command. The `status` command is also extended to accommodate the local network.
b-zee
reviewed
Jan 9, 2024
Comment on lines
+143
to
+144
| #[clap(long)] | ||
| count: Option<u16>, |
There was a problem hiding this comment.
Either set a default with clap or make sure it's documented what happens when --count isn't used.
Suggested change
| #[clap(long)] | |
| count: Option<u16>, | |
| #[clap(long, default_value_t = DEFAULT_NODE_COUNT)] | |
| count: u16, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this commit also contains the corresponding
killcommand. I accidentally amended it and couldn't untangle the changes from it without losing them.Spin up
safenodeprocesses, along with a faucet, to run a local network. These processes are not defined as services because they are not intended to be long running; they are for experimentation.As in the
testnetbinary, the network is validated, but unlike intestnetthe logs are not inspected. We just query each RPC service to check that peers are connected.At present you need to supply paths to both binaries, but this will be extended shortly to provide the ability to run downloaded binaries.
The node registry was extended to keep track of the faucet process so it can easily be cleaned up in a subsequent
killcommand.The
statuscommand is also extended to accommodate the local network.