This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
chore: manually parse environment variable #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-zee
approved these changes
Jan 15, 2024
jacderida
force-pushed
the
safe-peers-arg
branch
from
fd30a2f to
d8f1304
Compare
On the `join` command, the peers argument is set as an option so we are not required to specify any peers when adding additional nodes to an existing local network. When the argument is set as an option, it doesn't parse the environment variable if it's set, so unfortunately we also have to provide some manual parsing. The commit also removes the node registry definition, which has been moved to `sn_protocol`. The churn tests in `safe_network` CI now need to be able to parse the node manager's deployment inventory so they can restart local nodes.
jacderida
force-pushed
the
safe-peers-arg
branch
from
d8f1304 to
e8d9f2b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the
joincommand, the peers argument is set as an option so we are not required to specify any peers when adding additional nodes to an existing local network. When the argument is set as an option, it doesn't parse the environment variable if it's set, so unfortunately we also have to provide some manual parsing.The commit also removes the node registry definition, which has been moved to
sn_protocol. The churn tests insafe_networkCI now need to be able to parse the node manager's deployment inventory so they can restart local nodes.