This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
feat: add quic/tcp features and set quic as default #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-zee
reviewed
Jan 17, 2024
src/local.rs
Outdated
| "/ip4/127.0.0.1/tcp/{port}/p2p/{peer_id}" | ||
| ))?) | ||
| } else | ||
| // efault to quic |
There was a problem hiding this comment.
Typo. Maybe also use #[cfg(feature = "quic")] like below to keep it consistent.
There was a problem hiding this comment.
That should also force this library to be compiled with either quic or tcp, because it's not possible to compile without either feature.
b-zee
reviewed
Jan 17, 2024
src/service.rs
Outdated
| } else if cfg!(feature = "quic") { | ||
| UdpSocket::bind(("127.0.0.1", port)).is_ok() | ||
| } else { | ||
| false |
There was a problem hiding this comment.
Compiling this crate without either tcp and quic feature doesn't really make sense?
There was a problem hiding this comment.
aye, the compiler complained that it could still. I'm not sure of the best default strat here 🤔
b-zee
reviewed
Jan 17, 2024
src/local.rs
Outdated
| "/ip4/127.0.0.1/tcp/{port}/p2p/{peer_id}" | ||
| ))?) | ||
| if cfg!(feature = "tcp") { | ||
| #[cfg(feature = "tcp")] |
b-zee
approved these changes
Jan 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.