This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
feat: provide --peer argument
#6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The word `add` more accurately reflects what is happening here, since the command can add any number of services using the `--count` argument, and it is also intended to be used multiple times; you don't really run an installation more than once.
The `add` command is extended to provide a `--peer` argument. It uses the `sn_peers_acquisition` crate and thus parses them in the exact same way as `safenode`.
b-zee
approved these changes
Dec 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5c15c3a refactor: rename
installcommand toaddThe word
addmore accurately reflects what is happening here, since the command can add any numberof services using the
--countargument, and it is also intended to be used multiple times; youdon't really run an installation more than once.
056605e feat: provide
--peerargumentThe
addcommand is extended to provide a--peerargument. It uses thesn_peers_acquisitioncrate and thus parses them in the exact same way as
safenode.