Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the field name is properly added to the error message when the email address is blank. #74

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

iamdharmesh
Copy link
Collaborator

Description of the Change

As reported in #73, when attempting to submit the subscribe form without entering an email address, the error message did not include the field name, causing confusion about which field is incorrect and what needs to be fixed to submit the form successfully.

This PR introduces a minor fix to properly identify the field with the error, making the error message clear and specifically linked to the relevant form field.

Closes #73

How to test the Change

  1. Install and set up the plugin.
  2. Add the subscribe form using a block, widget, or shortcode.
  3. Visit the subscription form page on the front end, and click "Subscribe" without entering an email address.
  4. Ensure the error message is clear, identifies the field with the issue, and describes the related error.

Changelog Entry

Fixed - Ensure the field name is properly added to the error message when the email address is blank.

Credits

Props @jerclarke, @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter modified the milestones: Future Release, 1.7.0 Oct 29, 2024
@dkotter dkotter merged commit b86c227 into develop Oct 29, 2024
12 checks passed
@vikrampm1 vikrampm1 modified the milestones: 1.7.0, 1.6.2 Nov 11, 2024
@vikrampm1 vikrampm1 mentioned this pull request Nov 11, 2024
20 tasks
@dkotter dkotter deleted the fix/73 branch November 11, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing message when empty email value is submitted, should mention "email" not ": This value"
3 participants