Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove variable check in klipper config StreamParser #1435

Merged

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Jun 22, 2023

Description

This PR removes the jinja parsing of gcode variables. I think this is not necessary, because there is no jinja syntax possible.

Related Tickets & Documents

fixes #1433

Mobile & Desktop Screenshots/Recordings

image

[optional] Are there any post-deployment tasks we need to perform?

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested review from dw-0 and zellneralex June 22, 2023 21:50
@meteyou
Copy link
Member Author

meteyou commented Jun 22, 2023

@truckershitch pls review this PR.

@truckershitch
Copy link
Contributor

@meteyou Your PR / fix looks fine to me.

@meteyou meteyou merged commit 6e7ef65 into mainsail-crew:develop Jun 28, 2023
7 checks passed
@meteyou meteyou deleted the fix/remove-parsing-macro-variable branch June 28, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax Highlighting broken
3 participants