Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show delete dialog for single files too #1442

Merged
merged 3 commits into from
Jun 24, 2023

Conversation

dw-0
Copy link
Member

@dw-0 dw-0 commented Jun 24, 2023

Description

Previously only multiple selected files showed a confirm dialog on deletion. When deleting a single file via the context menu, the deletion was executed immediately. This PR implements the missing confirm dialog to prevent accidental deletes.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

image

[optional] Are there any post-deployment tasks we need to perform?

Signed-off-by: Dominik Willner <th33xitus@gmail.com>
@dw-0 dw-0 requested a review from meteyou June 24, 2023 21:42
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
pl.json 14 0

@dw-0 dw-0 linked an issue Jun 24, 2023 that may be closed by this pull request
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
pl.json 14 0

Signed-off-by: Dominik Willner <th33xitus@gmail.com>
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
pl.json 14 0

@meteyou meteyou merged commit 7da3352 into mainsail-crew:develop Jun 24, 2023
@dw-0 dw-0 deleted the single-file-delete-dialog branch June 24, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trash-bin feature like in Windows and Linux
2 participants