Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: display errors and warnings in the update_manager #1453

Merged

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Jul 4, 2023

Description

This PR display all update_manager errors from Moonraker and add warnings before you can update a component.

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

image

[optional] Are there any post-deployment tasks we need to perform?

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
…it to number

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
…ish it

Signed-off-by: Stefan Dej <meteyou@gmail.com>
…ish it

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
…o ServerUpdateManagerStateGitRepo

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested a review from dw-0 July 4, 2023 22:07
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 2

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
zh.json 44 2

src/locales/de.json Outdated Show resolved Hide resolved
src/locales/de.json Outdated Show resolved Hide resolved
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
zh.json 44 2

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
zh.json 44 2

meteyou and others added 2 commits July 16, 2023 22:55
Co-authored-by: rackrick <45207681+rackrick@users.noreply.github.com>
Co-authored-by: rackrick <45207681+rackrick@users.noreply.github.com>
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
zh.json 44 2

1 similar comment
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
zh.json 44 2

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
zh.json 44 2

src/locales/de.json Outdated Show resolved Hide resolved
src/locales/de.json Outdated Show resolved Hide resolved
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
zh.json 44 2

Co-authored-by: rackrick <45207681+rackrick@users.noreply.github.com>
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
zh.json 44 2

src/locales/de.json Outdated Show resolved Hide resolved
src/locales/de.json Outdated Show resolved Hide resolved
src/locales/de.json Outdated Show resolved Hide resolved
src/locales/de.json Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
src/locales/de.json Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
Co-authored-by: th33xitus <domwil1091+github@gmail.com>
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
pl.json 30 2
zh.json 44 2

@meteyou meteyou merged commit 0cefa24 into mainsail-crew:develop Jul 22, 2023
@meteyou meteyou deleted the feat/add-update-manager-last-error branch July 22, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants