fix: avoid hitting 100% before print is complete #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteyou
approved these changes
Jul 8, 2023
dw-0
approved these changes
Jul 8, 2023
The existing implementation will report 100% from 99.5% on, due to round(). Switching to floor() instead, which will report 99% until complete. Signed-off-by: Jamin W. Collins <jamin.collins@gmail.com>
meteyou
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation will report 100% from 99.5% on, due to round(). Switching to floor() instead, which will report 99% until complete.
Description
This PR fixes a display bug where prints will report 100% anytime they are at 99.5% or higher.
Related Tickets & Documents
There is a Discord support thread:
https://discord.com/channels/758059413700345988/1126955424999035061
Mobile & Desktop Screenshots/Recordings
[optional] Are there any post-deployment tasks we need to perform?
no