fix: fix issue on tablet and smaller devices with the sidebar #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: meteyou <meteyou@gmail.com>
|
As someone who experienced this bug with 2.7.0, I can confirm that the PR fixes it. I've seen no other side effects. |
rackrick
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with the sidebar on tablets and smaller devices. If you click a navi point and the sidebar will hide, the space behind the sidebar will not be blank anymore. The sidebar will push the new state to the Vuex store to remove the padding left of the main container.
Related Tickets & Documents
none open issues
Mobile & Desktop Screenshots/Recordings
before:
after:
[optional] Are there any post-deployment tasks we need to perform?