-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add devices dialog in editor #1765
feat: add devices dialog in editor #1765
Conversation
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
…_name Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Language file analysis report:
|
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Signed-off-by: Stefan Dej <meteyou@gmail.com>
…m device Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Language file analysis report:
|
Would it be possible to get a scroll bar in the UI, it is not intuitive if you have multiple MCUs that you have to scroll down to see them. |
@ccatlett1984 there is already a scrollbar in this dialog... |
I'll have to try another theme, I'll attach screenshots.
…On Sat, Feb 17, 2024, 9:14 AM Stefan Dej ***@***.***> wrote:
@ccatlett1984 <https://github.com/ccatlett1984> there is already a
scrollbar in this dialog...
—
Reply to this email directly, view it on GitHub
<#1765 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABY4LWLWQPKYCQ2QDVQDXY3YUC3MFAVCNFSM6AAAAABCXENMR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJQGIZDAMZSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
If you use a theme other than the Mainsail standard themes, you are more or less on your own, or on the creator of the theme. During development, we really can't take into account that custom themes don't break. Likewise, we cannot guarantee that features will always be displayed correctly with custom themes in addition to the Mainsail standard themes. That is simply impossible. Apart from that, if I expect a list of something to be displayed and don't see it directly, it's intuitive in my eyes to try scrolling first and see if/what happens. Regardless of whether I see a scrollbar or not. But maybe that's just me... |
Completely understandable, I'll try switching themes.
…On Sat, Feb 17, 2024, 10:11 AM dw-0 ***@***.***> wrote:
I'll have to try another theme, I'll attach screenshots.
If you use a theme other than the Mainsail standard themes, you are more
or less on your own, or on the creator of the theme. During development, we
really can't take into account that custom themes don't break. Likewise, we
cannot guarantee that features will always be displayed correctly with
custom themes in addition to the Mainsail standard themes. That is simply
impossible.
image.png (view on web)
<https://github.com/mainsail-crew/mainsail/assets/31533186/028f087d-4930-4865-93ae-c054be7f2057>
—
Reply to this email directly, view it on GitHub
<#1765 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABY4LWN3Y4D6WXVGYJJO573YUDCC7AVCNFSM6AAAAABCXENMR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJQGIZTENBWGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Description
This PR adds a popup dialog for searching CAN, Serial, USB or Video devices in the editor.
Related Tickets & Documents
PR in Moonraker to add this feature: Arksine/moonraker#798
Mobile & Desktop Screenshots/Recordings
[optional] Are there any post-deployment tasks we need to perform?