chore(deps): Update @sindarius/gcodeviewer (#1755) #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update @sindarius/gcodeviewer to latest after fix in upstream library. First update (d34aa64) was to include OrcaSlicer in the supported slicers list; unfortunately it was including a bug where unlisted slicer features where aborting the rendering. The new fix in the upstream library ensures that if supported slicers will add new features the render will continue to work and unsupported features will have a generic color instead of abort the render and throw an error. See Sindarius/npm_gcodeviewer@be58cce
meteyou
approved these changes
Feb 17, 2024
|
Thx! I followed your your conversion in the Sindarius/npm_gcodeviewer already. Thanks for fixing this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update @sindarius/gcodeviewer to latest after fix in upstream library.
First update (d34aa64) was to include OrcaSlicer in the supported slicers list; unfortunately it was including a bug where unlisted slicer features where aborting the rendering.
The new fix in the upstream library ensures that if supported slicers will add new features the render will continue to work and unsupported features will have a generic color instead of abort the render and throw an error.
Related Tickets & Documents
#1752
Sindarius/npm_gcodeviewer#13
Sindarius/npm_gcodeviewer@be58cce
Mobile & Desktop Screenshots/Recordings
No visual change
[optional] Are there any post-deployment tasks we need to perform?
No