Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix long M117 outputs in the status panel #1800

Merged

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Mar 2, 2024

Description

This PR fix long M117 outputs in the status panel.

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

before:
image

after:
image

[optional] Are there any post-deployment tasks we need to perform?

none

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested review from dw-0 and rackrick March 2, 2024 20:15
Copy link
Member

@rackrick rackrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error only reproducible with status text without any spaces. who use such texts? oO

@meteyou
Copy link
Member Author

meteyou commented Mar 7, 2024

Long gcode filenames also create this issue, because klipper posts it at the print start. I don't think that this happens with normal macro outputs.

here is an example:
no_name

@meteyou meteyou merged commit 0c6de24 into mainsail-crew:develop Mar 7, 2024
8 checks passed
@meteyou meteyou deleted the fix/fix-long-lines-status-messages branch March 7, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants