Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for klipper runtime warnings #1809

Merged

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Mar 6, 2024

Description

This PR add the support for Klipper Runtime Warnings. It only changes the headline from this notification warning.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

image

[optional] Are there any post-deployment tasks we need to perform?

  • publish the docs page:
    image

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested review from dw-0 and rackrick March 6, 2024 21:09
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

Copy link
Member

@rackrick rackrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type: 'deprecated_value' | 'deprecated_option'

the type object should be extended to match the new runtime_warning type

… attribute

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

Signed-off-by: Stefan Dej <meteyou@gmail.com>
Copy link
Contributor

github-actions bot commented Mar 9, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

@meteyou meteyou merged commit 98d9d8c into mainsail-crew:develop Apr 5, 2024
10 checks passed
@meteyou meteyou deleted the feat/add-klippper-runtime-warning branch April 5, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants