Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extruderPanel): add speed_factor to estimate extrusion calc #1913

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Jun 16, 2024

Description

This PR add the speed_factor to the estimate extrusion calculation and add a tooltip, when speed_factor and/or extrusion_factor is not 1.

Related Tickets & Documents

fixes: #1904

Mobile & Desktop Screenshots/Recordings

image

[optional] Are there any post-deployment tasks we need to perform?

none

Signed-off-by: Stefan Dej <meteyou@gmail.com>
(cherry picked from commit 4b17999)
@meteyou meteyou requested review from dw-0 and rackrick June 16, 2024 13:38
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 16, 2024
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 22, 2024
@meteyou meteyou changed the title fix(extruderPanel): add speed_factor to estimate extrusion calculation fix(extruderPanel): add speed_factor to estimate extrusion calc Jun 23, 2024
@meteyou meteyou merged commit 3fb988a into mainsail-crew:develop Jun 23, 2024
11 checks passed
@meteyou meteyou deleted the fix/extrusion-calculation branch June 23, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extruder panel: The estimated flow rate information doesn't account for the speed factor
2 participants